add area & area_percent statistics#169
Open
diversoft wants to merge 2 commits intoperrygeo:masterfrom
Open
Conversation
Owner
|
@diversoft thanks for the PR. Two comments:
|
perrygeo
requested changes
Jan 15, 2023
| if rast.src is not None: | ||
| cellsize = rast.src.res[0] * rast.src.res[1] | ||
| else: | ||
| cellsize = rast.affine.a * rast.affine.a |
Owner
There was a problem hiding this comment.
Suggested change
| cellsize = rast.affine.a * rast.affine.a | |
| cellsize = rast.affine.a * rast.affine.e |
Owner
There was a problem hiding this comment.
The cells size shouldn't be assumed to be square. It's very rare in practice to see rasters where a != e but it could happen
There was a problem hiding this comment.
I think you need the absolute value here: abs(rast.affine.a * rast.affine.e)
Contributor
There was a problem hiding this comment.
To be safe, I would recommend reprojecting to be sure. I implemented a utility function for this use-case here - https://github.com/WFP-VAM/prism-app/pull/893/files#diff-0e7a305eb2d7da6652444269a99141f2a18d2fb8ea0ddbc045cd6c5a16e2ee9bR104
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.